Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmalloc option build fix. #8465

Open
wants to merge 1 commit into
base: PHP-8.0
Choose a base branch
from
Open

Conversation

devnexen
Copy link
Member

error: expected declaration specifiers or ‘...’ before string constant 32 | extern int posix_memalign (void **, size_t, size_t);

@devnexen devnexen changed the title dmalloc build fix. dmalloc option build fix. Apr 29, 2022
@devnexen devnexen changed the base branch from master to PHP-8.0 April 29, 2022 16:12
@devnexen devnexen requested a review from iluuu1994 June 3, 2022 09:44
@iluuu1994
Copy link
Member

Do you know which of the includes actually caused the issue? Maybe we should fix that too (include the right dependency from there).

@devnexen
Copy link
Member Author

devnexen commented Jun 3, 2022

/usr/lib/gcc/x86_64-linux-gnu/11/include/mm_malloc.h:32:12: error: expected declaration specifiers or ‘...’ before string constant 32 | extern int posix_memalign (void **, size_t, size_t);

@devnexen
Copy link
Member Author

devnexen commented Jun 9, 2022

reordering sounds enough to fix the issue.

@Girgias
Copy link
Member

Girgias commented Jun 20, 2022

Could you do a rebase and force push just to run CI once more?

@iluuu1994
Copy link
Member

To be honest, I don't quite understand why importing local files first fixes the issue, I couldn't install dmalloc easily to test this for myself. I'm indifferent to the change, but usually it does make more sense to import libraries first and then local files.

`error: expected declaration specifiers or ‘...’ before string constant
   32 | extern int posix_memalign (void **, size_t, size_t);`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants